Workflows: Event decryption#510
Merged
mistralai-nfau merged 7 commits intomainfrom May 6, 2026
Merged
Conversation
anth2o
reviewed
May 6, 2026
Contributor
anth2o
left a comment
anth2o
left a comment
There was a problem hiding this comment.
@mistralai-nfau is it possible to add tests for the methods you added in this PR ?
|
|
||
| return data, encoding_options | ||
|
|
||
| async def encode_event_payload_content( |
Contributor
There was a problem hiding this comment.
very nit: here the name is encode_event_payload_content, not consistent with decode_event_payload, can we unify the 2 ?
Contributor
Author
There was a problem hiding this comment.
Actually it's consistent, but you must compare it to decode_network_result, it actually take a whole event payload, extract the encoding options and extracting payload value, open to renaming suggestion if any !
anth2o
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.